fix: set an explicit GOROOT in the Docker image for go-critic (#3106)

golangci · Aug 21, 2022 · 970b0a5 · 970b0a5
1 parent 63b2fe0
commit 970b0a5
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 2 deletions.
diff --git a/.gitattributes b/.gitattributes
@@ -1,2 +1 @@
 go.sum linguist-generated
-Dockerfile.* linguist-language=Dockerfile
diff --git a/.github/workflows/tag.yml b/.github/workflows/tag.yml
@@ -37,7 +37,7 @@ jobs:
       matrix:
         target:
           - Dockerfile: build/Dockerfile
-          - Dockerfile: build/Dockerfile.alpine
+          - Dockerfile: build/alpine.Dockerfile
     steps:
       - uses: actions/checkout@v3
 

diff --git a/build/Dockerfile b/build/Dockerfile
@@ -11,6 +11,8 @@ RUN CGO_ENABLED=0 go build -trimpath -ldflags "-s -w -X main.version=$VERSION -X
 
 # stage 2
 FROM golang:1.19
+# related to https://github.com/golangci/golangci-lint/issues/3107
+ENV GOROOT /usr/local/go
 # don't place it into $GOPATH/bin because Drone mounts $GOPATH as volume
 COPY --from=builder /golangci/golangci-lint /usr/bin/
 CMD ["golangci-lint"]
diff --git a/build/Dockerfile.alpine → build/alpine.Dockerfile b/build/Dockerfile.alpine → build/alpine.Dockerfile
@@ -16,6 +16,8 @@ RUN CGO_ENABLED=0 go build -trimpath -ldflags "-s -w -X main.version=$VERSION -X
 
 # stage 2
 FROM golang:1.19-alpine
+# related to https://github.com/golangci/golangci-lint/issues/3107
+ENV GOROOT /usr/local/go
 # gcc is required to support cgo;
 # git and mercurial are needed most times for go get`, etc.
 # See https://github.com/docker-library/golang/issues/80