Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unparam linter? #124

Closed
ryboe opened this issue Jun 22, 2018 · 2 comments
Closed

add unparam linter? #124

ryboe opened this issue Jun 22, 2018 · 2 comments
Labels
linter: new Support new linter

Comments

@ryboe
Copy link
Contributor

ryboe commented Jun 22, 2018

unparam is one of the few gometalinter linters missing from golangci-lint. It catches unused function parameters. I don't know if it's worthwhile. Maybe that functionality is already handled by another linter? I'd like to hear from golangci about whether this is worth adding. Thanks!

@jirfag jirfag added the linter: new Support new linter label Jun 24, 2018
golangci pushed a commit that referenced this issue Jun 30, 2018
1. Support unparam linter and fix found issues
2. Replace forked mvdan.cc/lint and mvdan.cc/interfacer with the
upstream ones
3. Minimize forked megacheck: move the most of it's code to this repo
4. Use golang.org/x/tools/go/ssa import path instead of custom fork
paths
5. In golang.org/x/tools/go/{ssa,callgraph} use changed code from
honnef.co/go/tools
6. Add megacheck.check-unexported option: it found some issues in
the repo, fixed them all
golangci pushed a commit that referenced this issue Jun 30, 2018
1. Support unparam linter and fix found issues
2. Replace forked mvdan.cc/lint and mvdan.cc/interfacer with the
upstream ones
3. Minimize forked megacheck: move the most of it's code to this repo
4. Use golang.org/x/tools/go/ssa import path instead of custom fork
paths
5. In golang.org/x/tools/go/{ssa,callgraph} use changed code from
honnef.co/go/tools
6. Add megacheck.check-unexported option: it found some issues in
the repo, fixed them all
@jirfag jirfag closed this as completed in a6b91cc Jun 30, 2018
@jirfag
Copy link
Member

jirfag commented Jun 30, 2018

hi,
supported unparam in #141

@ryboe
Copy link
Contributor Author

ryboe commented Jun 30, 2018

You're my hero, dude.

@jirfag jirfag added this to Done in Support more linters Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linter: new Support new linter
Projects
No open projects
Development

No branches or pull requests

2 participants