Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nolintlint: invalid linter name after autofix #1579

Closed
ldez opened this issue Dec 27, 2020 · 1 comment · Fixed by #1583
Closed

nolintlint: invalid linter name after autofix #1579

ldez opened this issue Dec 27, 2020 · 1 comment · Fixed by #1583
Assignees
Labels
bug Something isn't working

Comments

@ldez
Copy link
Member

ldez commented Dec 27, 2020

Related to #1573

before the fix:

// wantedErrors parses expected errors from comments in a file.
//nolint:nakedret, gocyclo
func wantedErrors(file, short string) (errs []wantedError) {

or

// wantedErrors parses expected errors from comments in a file.
//nolint:nakedret,gocyclo
func wantedErrors(file, short string) (errs []wantedError) {

after the fix:

// wantedErrors parses expected errors from comments in a file.
//nolint:nakedreto
func wantedErrors(file, short string) (errs []wantedError) {

KO


before the fix:

// wantedErrors parses expected errors from comments in a file.
//nolint:gocyclo, nakedret
func wantedErrors(file, short string) (errs []wantedError) {

or

// wantedErrors parses expected errors from comments in a file.
//nolint:gocyclo, nakedret
func wantedErrors(file, short string) (errs []wantedError) {

after the fix:

// wantedErrors parses expected errors from comments in a file.
//nolint:nakedrett
func wantedErrors(file, short string) (errs []wantedError) {

KO

@ldez ldez added the bug Something isn't working label Dec 27, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Dec 27, 2020

Hey, thank you for opening your first Issue ! 🙂 If you would like to contribute we have a guide for contributors.

ashanbrown added a commit that referenced this issue Dec 27, 2020
…nolint statements (#1573)" (#1584)

This reverts commit aeb9830.

There are some cases that nolinter fixer wasn't handling properly or expectedly (#1579, #1580, #1581) so we'll fix those in a new attempt.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants