Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forbidigo uses makezero in the lint reports #1589

Closed
3 tasks done
SVilgelm opened this issue Dec 28, 2020 · 1 comment · Fixed by #1590
Closed
3 tasks done

forbidigo uses makezero in the lint reports #1589

SVilgelm opened this issue Dec 28, 2020 · 1 comment · Fixed by #1590
Assignees
Labels
bug Something isn't working

Comments

@SVilgelm
Copy link
Member

Thank you for creating the issue!

  • Yes, I'm using a binary release within 2 latest major releases. Only such installations are supported.
  • Yes, I've searched similar issues on GitHub and didn't find any.
  • Yes, I've included all information below (version, config, etc).

I enabled forbidigo and got these errors:

internal/i18n/main.go:15:2: use of `fmt.Println` forbidden by pattern `^fmt\.Print(|f|ln)$` (makezero)
        fmt.Println(string(i18n.GenerateJSON()))
        ^
pkg/cmd/gen/i18n/i18n.go:17:2: use of `fmt.Println` forbidden by pattern `^fmt\.Print(|f|ln)$` (makezero)
        fmt.Println(string(i18n.GenerateJSON()))
        ^
pkg/cmd/gen/config/config.go:55:2: use of `fmt.Println` forbidden by pattern `^fmt\.Print(|f|ln)$` (makezero)
        fmt.Println(string(data))
        ^

As you can see It uses makezero in the report

Issue was introduced in here: https://github.com/golangci/golangci-lint/pull/1569/files#diff-f0557183cd3a50b72b0c7c3477c73b79c2e8bdd805652fe7c234cc23bf661b95R49

the forbidigoName should be used instead of makezeroName

@SVilgelm SVilgelm added the bug Something isn't working label Dec 28, 2020
@SVilgelm
Copy link
Member Author

@ashanbrown I assigned issue to you, please fix it

ashanbrown added a commit that referenced this issue Dec 28, 2020
Fix cut-and-paste error with linter name.

Fixes #1589
ashanbrown added a commit to ashanbrown/golangci-lint that referenced this issue Feb 20, 2021
Fix cut-and-paste error with linter name.

Fixes golangci#1589
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants