Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support overriding in WSL #1737

Closed
alenkacz opened this issue Feb 16, 2021 · 3 comments · Fixed by #1750
Closed

Support overriding in WSL #1737

alenkacz opened this issue Feb 16, 2021 · 3 comments · Fixed by #1750
Assignees
Labels
dependencies Relates to an upstream dependency enhancement New feature or improvement

Comments

@alenkacz
Copy link

Is your feature request related to a problem? Please describe.
Make it possible to pass this through wsl config https://github.com/bombsimon/wsl/blob/a6e08b33286b24ec81b47c17b60608e8b02a69f5/wsl.go#L92
https://github.com/golangci/golangci-lint/blob/master/pkg/golinters/wsl.go

Describe the solution you'd like
Add new config setting for golangcilint and pass it through to wsl

@alenkacz alenkacz added the enhancement New feature or improvement label Feb 16, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Feb 16, 2021

Hey, thank you for opening your first Issue ! 🙂 If you would like to contribute we have a guide for contributors.

@alenkacz
Copy link
Author

I can contribute this if I get a 👍 that this feature would be accepted

@bombsimon
Copy link
Member

Hi! I'm the author of wsl and I just created a new release so you you can bump the version in golangci-lint. I had plans last year to do a re-write but didn't finish it so this is about time. It's currently four fixed issues not merged upstream to golangci-lint so that would be nice!

Please feel free to bump wsl to v3.2.0 and add the missing configuration settings so they match 1:1 and we'll approve/merge.

@bombsimon bombsimon added the dependencies Relates to an upstream dependency label Feb 16, 2021
@bombsimon bombsimon assigned bombsimon and unassigned alenkacz Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Relates to an upstream dependency enhancement New feature or improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants