Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation in a restricted CI environment #233

Closed
kishaningithub opened this issue Sep 26, 2018 · 0 comments
Closed

Installation in a restricted CI environment #233

kishaningithub opened this issue Sep 26, 2018 · 0 comments

Comments

@kishaningithub
Copy link
Contributor

Problem 1

In restricted go ci agents i often find that access to install.goreleaser.com is blocked where as raw.githubusercontent.com is not.

Proposed solution

If install script file is checked in as part of the repo it can be retrived via raw.githubusercontent.com. Currently dep project has an install.sh file enabling it to be "curled" from raw.githubusercontent.com

Installation from install.goreleaser.com can still and always remain the primary mode of installation and raw.githubusercontent.com can be a backup

Problem 2

In readme

curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | bash -s -- -b $GOPATH/bin vX.Y.Z

In alpine linux boxes bash will not be present

Proposed solution

Replace the installation script in read me as

curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh

If you are fine with this i will submit a PR 🙂

@kishaningithub kishaningithub changed the title Installation in a restricted CI envirionment Installation in a restricted CI environment Sep 28, 2018
kishaningithub added a commit to kishaningithub/golangci-lint that referenced this issue Sep 28, 2018
@jirfag jirfag closed this as completed in 59c3d20 Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant