Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Way to install latest release from install.sh has changed #3512

Closed
herman26 opened this issue Jan 28, 2023 · 1 comment · Fixed by #3513
Closed

Way to install latest release from install.sh has changed #3512

herman26 opened this issue Jan 28, 2023 · 1 comment · Fixed by #3513
Labels
area: install Issue relates to installation or downloading process bug Something isn't working

Comments

@herman26
Copy link
Contributor

herman26 commented Jan 28, 2023

Your feature request related to a problem? Please describe.

Hi we installed the latest version golangci using the following command wget -O- -nv https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s latest, with the latest commit from d57156e, this won't work anymore, could line 320 if [ -z "$version" ] then be changed to if [ -z "$version" ] || [ "$version" = "latest" ]; then to allow the previous command to work as it should, I suspect this might be affecting many users?

Describe the solution you'd like.

Instead of doing if [ -z "$version" ] then on line 320, could you do if [ -z "$version" ] || [ "$version" = "latest" ]; then?

Describe alternatives you've considered.

Alternative here would to be to update our pipelines to the new way of installing latest - wget -O- -nv https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh but again I'm assuming this must be affecting many users.

Additional context.

Many people are using this in their pipelines and it could be affecting them negatively.

Related to #3509

@herman26 herman26 added the enhancement New feature or improvement label Jan 28, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 28, 2023

Hey, thank you for opening your first Issue ! 🙂 If you would like to contribute we have a guide for contributors.

@ldez ldez added bug Something isn't working area: install Issue relates to installation or downloading process and removed enhancement New feature or improvement labels Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: install Issue relates to installation or downloading process bug Something isn't working
Projects
None yet
2 participants