Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix install script (revert) #3514

Merged
merged 2 commits into from
Jan 28, 2023
Merged

Conversation

ldez
Copy link
Member

@ldez ldez commented Jan 28, 2023

GitHub engineers have pushed a change that has reverted the bug, so we can revert the changes.

https://github.com/orgs/community/discussions/45590#discussioncomment-4802887

The problem with the changes is the use of the API, this requires a GitHub token to avoid rate limits.

https://github.com/orgs/community/discussions/45590#discussioncomment-4802681

related to #3509, #3510, #3511, #3512, #3513.

@ldez ldez added bug Something isn't working area: install Issue relates to installation or downloading process labels Jan 28, 2023
@ldez
Copy link
Member Author

ldez commented Jan 28, 2023

I consider this as high priority fix, and as this is just a revert, I will merge without review.
This is exceptional given the situation.

@ldez ldez merged commit 9a8a056 into golangci:master Jan 28, 2023
@ldez ldez deleted the fix/install-script branch January 28, 2023 14:23
SeigeC pushed a commit to SeigeC/golangci-lint that referenced this pull request Apr 4, 2023
@ldez ldez added this to the v1.51 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: install Issue relates to installation or downloading process bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant