Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deadline exceeded should returns 1 instead of 0 #41

Closed
quantonganh opened this issue May 29, 2018 · 3 comments
Closed

deadline exceeded should returns 1 instead of 0 #41

quantonganh opened this issue May 29, 2018 · 3 comments
Labels
bug Something isn't working

Comments

@quantonganh
Copy link 

...
INFO[0082] processing took 667.366µs with stages: max_same_issues: 664.846µs, max_from_linter: 1.138µs, path_prettifier: 394ns, cgo: 227ns, exclude: 203ns, diff: 181ns, nolint: 173ns, max_per_file_from_linter: 154ns, uniq_by_line: 50ns
WARN[0082] 0/9 linters finished: deadline exceeded: try increase it by passing --deadline option
Congrats! No issues were found.
INFO[0082] Extracting issued lines took 0s

❯❯❯❯ echo $?
0
golangci pushed a commit that referenced this issue May 30, 2018
@golangcidev
#41: exit with code 4 if timeouted
b28bf5f
golangci pushed a commit that referenced this issue May 30, 2018
Merge pull request #44 from golangci/support/exit-code-4-if-deadline
3b5ee0c 
#41: exit with code 4 if timeouted
@golangci
Copy link
Collaborator

@quantonganh thank you!
fixed in #44, check in master, please

@golangci golangci added bug Something isn't working awaiting_for_check_by_author labels May 30, 2018
@quantonganh
Copy link
Author 

WARN[0076] 0/9 linters finished: deadline exceeded: try increase it by passing --deadline option
Congrats! No issues were found.
INFO[0076] Workers idle times: #1: 84.316µs, #3: 72.969µs, #4: 92.428µs
INFO[0076] Extracting issued lines took 0s
❯❯❯❯ echo $?
4

Exit code is ok now but IMO, "Congrats! No issues were found." should not be printed.

@golangci
Copy link
Collaborator

golangci commented Jun 2, 2018

fixed "Congrats! No issues were found." in master

@golangci golangci closed this as completed Jun 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@quantonganh