Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nargs as a supported linter #553

Closed
palash25 opened this issue Jun 2, 2019 · 3 comments
Closed

Add nargs as a supported linter #553

palash25 opened this issue Jun 2, 2019 · 3 comments
Labels
linter: new Support new linter

Comments

@palash25
Copy link

palash25 commented Jun 2, 2019

Thank you for creating the issue!

Please include the following information:

  1. Version of golangci-lint: golangci-lint --version (or git commit if you don't use binary distribution)
  2. Config file: cat .golangci.yml
  3. Go environment: go version && go env
  4. Verbose output of running: golangci-lint run -v

https://github.com/alexkohler/nargs

@tpounds tpounds added the linter: new Support new linter label Sep 29, 2019
@tpounds tpounds added the help wanted Issue that needs help from a contributor label Oct 8, 2019
@jirfag
Copy link
Member

jirfag commented Oct 14, 2019

hi,
why isn't unparam sufficient for you? it looks like a much less efficient version of unparam

@stale
Copy link

stale bot commented Apr 11, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale No recent correspondence or work activity label Apr 11, 2020
@stale stale bot closed this as completed May 11, 2020
@FdeFabricio
Copy link

There are some cases that unused parameters are ignored by unparam, called as "dummy implementation", which are not ignored by nargs. mvdan/unparam#49

In terms of efficiency, I don't know much...

@ldez ldez added linter: idea idea of a linter linter: new Support new linter and removed help wanted Issue that needs help from a contributor linter: new Support new linter stale No recent correspondence or work activity linter: idea idea of a linter labels Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linter: new Support new linter
Projects
None yet
Development

No branches or pull requests

5 participants