Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce gci as new linter #1266

Merged
merged 2 commits into from
Jul 28, 2020
Merged

Introduce gci as new linter #1266

merged 2 commits into from
Jul 28, 2020

Conversation

daixiang0
Copy link
Contributor

Related to #1257

Signed-off-by: Xiang Dai long0dai@foxmail.com

@daixiang0 daixiang0 changed the title Introduce gci as new linter [WIP] Introduce gci as new linter Jul 25, 2020
@daixiang0 daixiang0 changed the title [WIP] Introduce gci as new linter Introduce gci as new linter Jul 27, 2020
@daixiang0
Copy link
Contributor Author

please review @golangci/core-team

Copy link
Member

@ernado ernado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

test/testdata/gci.go Outdated Show resolved Hide resolved
Signed-off-by: Xiang Dai <long0dai@foxmail.com>
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from configuration point, lgtm 💯

Signed-off-by: Xiang Dai <long0dai@foxmail.com>
@daixiang0 daixiang0 requested a review from sayboras July 28, 2020 09:38
@ernado ernado merged commit 60613dc into golangci:master Jul 28, 2020
@daixiang0 daixiang0 deleted the gci branch July 29, 2020 00:51
@ldez ldez added the linter: new Support new linter label Dec 7, 2020
@ldez ldez added this to the v1.30 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linter: new Support new linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants