Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stringintconv and ifaceassert to govet #1360

Merged
merged 2 commits into from Feb 20, 2021
Merged

Add stringintconv and ifaceassert to govet #1360

merged 2 commits into from Feb 20, 2021

Conversation

SVilgelm
Copy link
Member

@SVilgelm SVilgelm commented Sep 8, 2020

Add new linters:

  • stringintconv, enabled by default
  • ifaceassert is additional linter

Move govet tests to a dedicated folder

Fix #1359

@SVilgelm SVilgelm marked this pull request as draft Sep 8, 2020
@SVilgelm
Copy link
Member Author

SVilgelm commented Sep 8, 2020

@bombsimon Something wrong here, it had to fail here: https://github.com/golangci/golangci-lint/pull/1360/files#diff-fec92a1aa6b31bf39c48b7934581c028R13

converted to draft

@bombsimon
Copy link
Member

bombsimon commented Sep 8, 2020

@bombsimon Something wrong here, it had to fail here: https://github.com/golangci/golangci-lint/pull/1360/files#diff-fec92a1aa6b31bf39c48b7934581c028R13

converted to draft

Oh, I was too quick. Will do a new review when converted to PR again!

@ldez ldez added the linter: new Support new linter label Dec 27, 2020
@ldez
Copy link
Member

ldez commented Feb 18, 2021

@SVilgelm could you allow me to continue your PR?

FYI it's not possible to put the tests inside a dedicated folder because the tests are never run by make test_linters.

@ldez
Copy link
Member

ldez commented Feb 20, 2021

@SVilgelm friendly ping

FYI I already prepared a fix.

Sergey Vilgelm and others added 2 commits Feb 20, 2021
Add new linters:
* stringintconv, enabled by default
* ifaceassert is additional linter

Move govet tests to a dedicated folder
@ldez
Copy link
Member

ldez commented Feb 20, 2021

FYI I don't really want to open a new PR because you have already done 99,999% of the job.

As this PR has been open for 6 months, I suppose that you don't have time to spend on that PR.

I take your silence as a "yes" and I will rebase and fix the PR.

@ldez ldez marked this pull request as ready for review Feb 20, 2021
@SVilgelm
Copy link
Member Author

SVilgelm commented Feb 20, 2021

Sorry, I actually have no enough time and already forgot about this PR :)
Feel free to use it

@SVilgelm
Copy link
Member Author

SVilgelm commented Feb 20, 2021

@ldez you can merge it anytime

ldez
ldez approved these changes Feb 20, 2021
Copy link
Member

@ldez ldez left a comment

LGTM

@ldez ldez merged commit f00da2c into master Feb 20, 2021
19 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix-1359 branch Feb 20, 2021
ashanbrown pushed a commit to ashanbrown/golangci-lint that referenced this pull request Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linter: new Support new linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing warning for string(x)
3 participants