update exhaustive to latest; use version in go.mod #1449
Conversation
|
Tests are failing. I'll update. |
go.mod
Outdated
| @@ -37,7 +37,7 @@ require ( | |||
| github.com/mitchellh/go-ps v1.0.0 | |||
| github.com/moricho/tparallel v0.2.1 | |||
| github.com/nakabonne/nestif v0.3.0 | |||
| github.com/nishanths/exhaustive v0.0.0-20200811152831-6cf413ae40e0 | |||
| github.com/nishanths/exhaustive v0.0.0-20201012211509-7221e29c71f4 | |||
There was a problem hiding this comment.
as you are maintainer of exhaustive, can you release tag version vX.Y.Z ? so that going forward dependenbot will just update it automatically ?
There was a problem hiding this comment.
I am, I'll do that.
|
This should be ready to review. |
|
Once this is merged, can I request a new release of golangci-lint? A user is affected by a false positive that is fixed by this change: nishanths/exhaustive#3 |
| @@ -102,6 +102,8 @@ linters-settings: | |||
| # see https://github.com/kisielk/errcheck#excluding-functions for details | |||
| exclude: /path/to/file.txt | |||
| exhaustive: | |||
| # check switch statements in generated files also | |||
| check-generated: false | |||
There was a problem hiding this comment.
This is a new flag in exhaustive.
nishanths
changed the title
| @@ -9,8 +9,6 @@ linters-settings: | |||
| - github.com/sirupsen/logrus: "logging is allowed only by logutils.Log" | |||
| dupl: | |||
| threshold: 100 | |||
| exhaustive: | |||
| default-signifies-exhaustive: false | |||
There was a problem hiding this comment.
Removing because this is just the default value. As @bombsimon said, no need to mention defaults in this file.
In my opinion, we are doing monthly realease, so can I wait till next week ? |
Yes, that works very well. |
This updates the exhaustive linter, and updates the dependency in go.mod to use vX.Y.Z format.
Mainly address issue #3.