Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docs and Assets Github Actions #1460

Merged
merged 10 commits into from Mar 3, 2021
Merged

Update Docs and Assets Github Actions #1460

merged 10 commits into from Mar 3, 2021

Conversation

neha-viswanathan
Copy link
Contributor

@neha-viswanathan neha-viswanathan commented Oct 19, 2020

Closes #1208

@boring-cyborg
Copy link

boring-cyborg bot commented Oct 19, 2020

Hey, thank you for opening your first Pull Request !

@CLAassistant
Copy link

CLAassistant commented Oct 19, 2020

CLA assistant check
All committers have signed the CLA.

@neha-viswanathan neha-viswanathan changed the title [wip] update Github Actions WIP: update Github Actions Oct 19, 2020
@neha-viswanathan neha-viswanathan changed the title WIP: update Github Actions update Github Actions Oct 19, 2020
sayboras
sayboras previously requested changes Oct 19, 2020
Copy link
Member

@sayboras sayboras left a comment

Thanks for your PR, I have one comment below. Another point to think about is pre-release and post-release, currently, I think it's ok to do all the step in post-release.

.github/workflows/tag.yml Outdated Show resolved Hide resolved
@sayboras sayboras requested review from a team Oct 19, 2020
@sayboras sayboras added area: ci PR that update CI hacktoberfest hacktoberfest hacktoberfest-accepted hacktoberfest PR topic: speed labels Oct 19, 2020
@neha-viswanathan neha-viswanathan requested review from sayboras and removed request for a team Oct 19, 2020
@neha-viswanathan neha-viswanathan changed the title update Github Actions WIP: update Github Actions Oct 19, 2020
@neha-viswanathan
Copy link
Contributor Author

neha-viswanathan commented Oct 19, 2020

Tested on my fork by creating a tag and here's the result:

image

@neha-viswanathan neha-viswanathan changed the title WIP: update Github Actions update Github Actions Oct 19, 2020
@sayboras sayboras requested review from a team Oct 19, 2020
@sayboras
Copy link
Member

sayboras commented Oct 19, 2020

@neha-viswanathan first glance looks good, will do proper review later. I have added team for another 👀 as well.

@sayboras
Copy link
Member

sayboras commented Oct 20, 2020

@neha-viswanathan correct me if I am wrong, based on your screen shot, the PR got created, but I can't find it in your forked repo. Can you share the link here ?

@neha-viswanathan
Copy link
Contributor Author

neha-viswanathan commented Oct 20, 2020

.github/workflows/tag.yml Outdated Show resolved Hide resolved
@neha-viswanathan neha-viswanathan changed the title update Github Actions WIP: update Github Actions Oct 23, 2020
@sayboras sayboras marked this pull request as draft Oct 23, 2020
@neha-viswanathan neha-viswanathan requested review from sayboras and removed request for a team Oct 24, 2020
@sayboras
Copy link
Member

sayboras commented Oct 24, 2020

Seems like you are making some changes, please share link to auto-generated PR in your forked repo as part of your testing.

@neha-viswanathan
Copy link
Contributor Author

neha-viswanathan commented Oct 25, 2020

@sayboras This is the link to the actions - i'm unable to run make update_contributors_list successfully
https://github.com/neha-viswanathan/golangci-lint/runs/1306304385

@sayboras
Copy link
Member

sayboras commented Oct 26, 2020

This is the link to the actions - i'm unable to run make update_contributors_list successfully
https://github.com/neha-viswanathan/golangci-lint/runs/1306304385

As this one never runs in github action before, I am not sure what the reason could be. The best you can do is to replicate it locally by cross checking npm/node/etc version in github action. This target is working fine for me. If you don't have time or can't figure it out, feel free to skip this make update_contributors_list step and carry on with your testing. The goal we want to achieve is having auto generated PR :)

@ldez
Copy link
Member

ldez commented Mar 3, 2021

The permissions are good now.

ldez
ldez previously requested changes Mar 3, 2021
.github/workflows/tag.yml Outdated Show resolved Hide resolved
Copy link
Member

@SVilgelm SVilgelm left a comment

@ldez let's merge it and release a new version

@ldez ldez merged commit 507703b into golangci:master Mar 3, 2021
18 checks passed
@golangci-automator
Copy link

golangci-automator bot commented Mar 3, 2021

Hey, @neha-viswanathan — we just merged your PR to golangci-lint! 🔥🚀

golangci-lint is built by awesome people like you. Let us say “thanks”: we just invited you to join the GolangCI organization on GitHub.
This will add you to our team of maintainers. Accept the invite by visiting this link.

By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.
More information about contributing is here.

Thanks again!

@SVilgelm
Copy link
Member

SVilgelm commented Mar 3, 2021

@ldez it's failed, I think that the @golangci-releaser user should be a member of the @golangci/team, according to the documentation https://docs.github.com/en/rest/reference/teams#members

@jirfag @ernado Could you please add the https://github.com/golangci-releaser user to the team?

@neha-viswanathan neha-viswanathan deleted the 1208-update-github-actions branch Mar 4, 2021
@ldez ldez mentioned this pull request Mar 4, 2021
This was referenced Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ci PR that update CI hacktoberfest hacktoberfest hacktoberfest-accepted hacktoberfest PR topic: speed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate update for github-action-config.json
6 participants