Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go1.16 support #1740

Merged
merged 6 commits into from
Feb 17, 2021
Merged

Add go1.16 support #1740

merged 6 commits into from
Feb 17, 2021

Conversation

ldez
Copy link
Member

@ldez ldez commented Feb 16, 2021

  • drop go1.13
  • add go1.16

We have to wait for the new alpine Docker image for go1.16 before merging the PR.
docker-library/official-images#9639

Also, we will have to update the CI check requirements settings in GitHub

Fixes #1725

@ldez ldez added the enhancement New feature or improvement label Feb 16, 2021
@ldez
Copy link
Member Author

ldez commented Feb 17, 2021

The error message returned by govet has been changed, so I don't know how we will handle that to be able to run the tests on go1.14 and go1.15

fixed

@ldez
Copy link
Member Author

ldez commented Feb 17, 2021

@ernado could you update the CI check requirements settings in GitHub?

@ernado
Copy link
Member

ernado commented Feb 17, 2021

Hey @ldez, I've updated settings, now it is required to pass go1.{14,15,16} and the go1.13 requirement was dropped.

@ldez ldez merged commit 123da8e into golangci:master Feb 17, 2021
@ldez ldez deleted the feat/go1.16 branch February 17, 2021 04:17
@sayboras
Copy link
Member

maybe it's time to cut off a new release as well ? I have been building from source for ttime being :(

@sayboras
Copy link
Member

The related changes in goreleaser goreleaser/goreleaser#1956 and https://github.com/goreleaser/goreleaser/releases/tag/v0.156.1.

Seems like it will just work without any update required for .goreleaser.yaml

@ldez
Copy link
Member Author

ldez commented Feb 17, 2021

@sayboras I agree, can we merge #1739 before?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install golangci-lint on Apple Silicon (darwin-arm64)
3 participants