Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean configuration and code #1830

Merged
merged 3 commits into from
Mar 9, 2021
Merged

Clean configuration and code #1830

merged 3 commits into from
Mar 9, 2021

Conversation

ldez
Copy link
Member

@ldez ldez commented Mar 9, 2021

  • clean imports
  • clean test imports
  • clean configuration

@ldez ldez added the topic: cleanup Related to code, process, or doc cleanup label Mar 9, 2021
@ldez ldez requested a review from SVilgelm March 9, 2021 18:13
bombsimon
bombsimon approved these changes Mar 9, 2021
View reviewed changes
Copy link
Member

@bombsimon bombsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ldez ldez merged commit 2ebc9d7 into golangci:master Mar 9, 2021
@ldez ldez deleted the feat/clean branch March 9, 2021 18:46
@ldez ldez added this to the v1.39 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bombsimon bombsimon bombsimon approved these changes

@SVilgelm SVilgelm Awaiting requested review from SVilgelm

Assignees
No one assigned
Labels
topic: cleanup Related to code, process, or doc cleanup
Projects
None yet
Milestone
v1.39
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ldez @bombsimon