Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump github.com/mgechev/revive from 1.0.8 to 1.0.9 #2113

Merged
merged 2 commits into from
Jul 13, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 12, 2021

Bumps github.com/mgechev/revive from 1.0.8 to 1.0.9.

Release notes

Sourced from github.com/mgechev/revive's releases.

v1.0.9

Changelog

daffd5f Fix a typo: "Rule tuning" (#539) 1acbe6b Fix testeability typo (#542) cfac8b0 fix 534 (#536) ea51f7a fix issue #537 (#538) 89f108c fix issue #540 (#543)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/mgechev/revive](https://github.com/mgechev/revive) from 1.0.8 to 1.0.9.
- [Release notes](https://github.com/mgechev/revive/releases)
- [Changelog](https://github.com/mgechev/revive/blob/master/.goreleaser.yml)
- [Commits](mgechev/revive@v1.0.8...v1.0.9)

---
updated-dependencies:
- dependency-name: github.com/mgechev/revive
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Relates to an upstream dependency go Pull requests that update Go code labels Jul 12, 2021
@dependabot dependabot bot requested a review from a team July 12, 2021 20:12
@rliebz
Copy link
Contributor

rliebz commented Jul 12, 2021

Not sure if this belongs as part of this change or a subsequent PR, but the default rules in revive have changed, meaning this repo should be updating the copied unexported code as well:

&rule.IfReturnRule{},

Not sure if anything else differs, but it might make sense to bump all of the copied code, rather than just that line.

Reference: https://github.com/mgechev/revive/pull/538/files#diff-fe44f09c4d5977b5f5eaea29170b6a0748819c9d02271746a20d81a5f3efca17L23

@ldez ldez added linter: update version Update version of linter and removed linter: update version Update version of linter labels Jul 12, 2021
@ldez ldez merged commit d913078 into master Jul 13, 2021
@delete-merged-branch delete-merged-branch bot deleted the dependabot/go_modules/github.com/mgechev/revive-1.0.9 branch July 13, 2021 00:07
@ldez ldez added linter: update version Update version of linter and removed dependencies Relates to an upstream dependency go Pull requests that update Go code labels Jul 14, 2021
SeigeC pushed a commit to SeigeC/golangci-lint that referenced this pull request Apr 4, 2023
@ldez ldez added dependencies Relates to an upstream dependency go Pull requests that update Go code labels Jun 16, 2023
@ldez ldez added this to the v1.42 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Relates to an upstream dependency go Pull requests that update Go code linter: update version Update version of linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants