Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Wrapcheck to v2.3 #2145

Merged
merged 2 commits into from
Aug 2, 2021
Merged

Update Wrapcheck to v2.3 #2145

merged 2 commits into from
Aug 2, 2021

Conversation

hn8
Copy link
Contributor

@hn8 hn8 commented Jul 31, 2021

Update ignoreSigs default, add ignorePackageGlobs

tomarrell/wrapcheck@v2.2.0...v2.3.0

Updat ignoreSigs default, add ignorePackageGlobs
@boring-cyborg
Copy link

boring-cyborg bot commented Jul 31, 2021

Hey, thank you for opening your first Pull Request !

@CLAassistant
Copy link

CLAassistant commented Jul 31, 2021

CLA assistant check
All committers have signed the CLA.

@ldez ldez added the linter: update version Update version of linter label Jul 31, 2021
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

the file .golangci.example.yml doesn't describe the default values but it provides an example of the linter's configuration.

.golangci.example.yml Outdated Show resolved Hide resolved
Co-authored-by: Ludovic Fernandez <ldez@users.noreply.github.com>
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomarrell
Copy link
Member

Thanks a bunch for sorting this.

@tomarrell tomarrell merged commit 6c295e4 into golangci:master Aug 2, 2021
@golangci-automator
Copy link

Hey, @hn8 — we just merged your PR to golangci-lint! 🔥🚀

golangci-lint is built by awesome people like you. Let us say “thanks”: we just invited you to join the GolangCI organization on GitHub.
This will add you to our team of maintainers. Accept the invite by visiting this link.

By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.
More information about contributing is here.

Thanks again!

SeigeC pushed a commit to SeigeC/golangci-lint that referenced this pull request Apr 4, 2023
* Update Wrapcheck to v2.3

Updat ignoreSigs default, add ignorePackageGlobs

* Update .golangci.example.yml

Co-authored-by: Ludovic Fernandez <ldez@users.noreply.github.com>

Co-authored-by: Ludovic Fernandez <ldez@users.noreply.github.com>
@ldez ldez added this to the v1.42 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linter: update version Update version of linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants