errcheck: update to HEAD #2213
Merged
errcheck: update to HEAD #2213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update removes some false positives wrt direct io.EOF comparison. Changes: https://github.com/polyfloyd/go-errorlint/compare/ab96adb96fea..910bb7978349 Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
|
Hey, thank you for opening your first Pull Request ! |
|
|
|
Hello @kolyshkin you have to sign the CLA. |
@ldez done |
SVilgelm
approved these changes
Sep 2, 2021
|
Hey, @kolyshkin — we just merged your PR to
By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests. Thanks again! |
SeigeC
pushed a commit
to SeigeC/golangci-lint
that referenced
this pull request
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update removes some false positives wrt direct io.EOF comparison (polyfloyd/go-errorlint#12, polyfloyd/go-errorlint#13)
Changes: https://github.com/polyfloyd/go-errorlint/compare/ab96adb96fea..910bb7978349