Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Include custom linters in enable-all #3085

Closed
wants to merge 2 commits into from

Conversation

yuqengo
Copy link

@yuqengo yuqengo commented Aug 9, 2022

Related to #3080

.golangci.yml

linters-settings:
  custom:
    example:
      path: ./example.so

linters:
  enable-all: true

Custom linters work for enable-all.

@boring-cyborg
Copy link

boring-cyborg bot commented Aug 9, 2022

Hey, thank you for opening your first Pull Request !

@CLAassistant
Copy link

CLAassistant commented Aug 9, 2022

CLA assistant check
All committers have signed the CLA.

@ldez ldez added the enhancement New feature or improvement label Aug 9, 2022
@yuqengo yuqengo marked this pull request as ready for review August 9, 2022 13:47
@ldez
Copy link
Member

ldez commented Aug 9, 2022

Hello,

for security reasons, I think it's a bad idea to do that.

@ldez ldez added the blocked Need's direct action from maintainer label Aug 9, 2022
@yuqengo
Copy link
Author

yuqengo commented Aug 9, 2022

Hello, Thanks for review!

What security reasons do you have?

@ldez
Copy link
Member

ldez commented Jun 12, 2023

I thought about the subject and I think there is a bug because the activation of plugins should be done by default.

linterConfig.EnabledByDefault = true

The current implementation inside golangci-lint has some design problems.

I think I will fix design problems and the behavior of the plugin in another PR.

@ldez ldez self-requested a review June 12, 2023 08:40
@yuqengo
Copy link
Author

yuqengo commented Jun 14, 2023

@ldez
hello idez !

The current implementation inside golangci-lint has some design problems.
I think I will fix design problems and the behavior of the plugin in another PR.

If you respond with another PR, Should this PR be closed ?

@ldez
Copy link
Member

ldez commented Jun 14, 2023

Yes, I will create a new PR tomorrow.

@yuqengo yuqengo closed this Jun 14, 2023
@ldez ldez added declined and removed blocked Need's direct action from maintainer labels Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
declined enhancement New feature or improvement linter: custom About custom/private linters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants