Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: rewrite the tests framework #3100

Merged
merged 2 commits into from
Aug 15, 2022
Merged

dev: rewrite the tests framework #3100

merged 2 commits into from
Aug 15, 2022

Conversation

ldez
Copy link
Member

@ldez ldez commented Aug 15, 2022 •
edited

The new "framework":

  • is more simple
  • is more robust
  • is more readable
  • provide more precise information when a test fails
  • has tests

@ldez ldez added enhancement New feature or improvement area: tests Continuous integration, tests and other checks labels Aug 15, 2022
@ldez ldez force-pushed the feat/rewrite-tests-framework branch 4 times, most recently from dddfb55 to 76325d6 Compare August 15, 2022 19:11
@ldez ldez force-pushed the feat/rewrite-tests-framework branch from 76325d6 to 13a2ea6 Compare August 15, 2022 19:25
bombsimon
bombsimon approved these changes Aug 15, 2022
View reviewed changes
Copy link
Member

@bombsimon bombsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, easy to read, easy to follow - thanks!❤️

@ldez
Copy link
Member Author

ldez commented Aug 15, 2022 •
edited

There is an interesting side effect: I was able to fix the flaky tests as the tests are more readable.
So I hope this is the end of the multiple and manual re-run of the CI.

@ldez ldez merged commit 5e14049 into golangci:master Aug 15, 2022
@ldez ldez deleted the feat/rewrite-tests-framework branch August 15, 2022 19:56
SeigeC pushed a commit to SeigeC/golangci-lint that referenced this pull request Apr 4, 2023
@ldez @SeigeC
dev: rewrite the tests framework (golangci#3100)
77a348b
@ldez ldez added this to the v1.49 milestone Mar 6, 2024
@ldez ldez mentioned this pull request Apr 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bombsimon bombsimon bombsimon approved these changes

Assignees
No one assigned
Labels
area: tests Continuous integration, tests and other checks enhancement New feature or improvement
Projects
None yet
Milestone
v1.49
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ldez @bombsimon