-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): bump github.com/nishanths/exhaustive from 0.8.1 to 0.8.3 #3207
Merged
ldez
merged 2 commits into
master
from
dependabot/go_modules/github.com/nishanths/exhaustive-0.8.3
Sep 11, 2022
Merged
build(deps): bump github.com/nishanths/exhaustive from 0.8.1 to 0.8.3 #3207
ldez
merged 2 commits into
master
from
dependabot/go_modules/github.com/nishanths/exhaustive-0.8.3
Sep 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [github.com/nishanths/exhaustive](https://github.com/nishanths/exhaustive) from 0.8.1 to 0.8.3. - [Release notes](https://github.com/nishanths/exhaustive/releases) - [Commits](nishanths/exhaustive@v0.8.1...v0.8.3) --- updated-dependencies: - dependency-name: github.com/nishanths/exhaustive dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
ldez
approved these changes
Sep 11, 2022
maratori
reviewed
Sep 11, 2022
exhaustive.IgnoreEnumMembersFlag: settings.IgnoreEnumMembers, | ||
exhaustive.PackageScopeOnlyFlag: settings.PackageScopeOnly, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why have you removed this config?
@@ -17,8 +17,9 @@ func NewExhaustive(settings *config.ExhaustiveSettings) *goanalysis.Linter { | |||
a.Name: { | |||
exhaustive.CheckGeneratedFlag: settings.CheckGenerated, | |||
exhaustive.DefaultSignifiesExhaustiveFlag: settings.DefaultSignifiesExhaustive, | |||
exhaustive.ExplicitExhaustiveMapFlag: settings.ExplicitExhaustiveMap, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing a new config - exhaustive.CheckFlag
Created PR with fixes #3212 |
SeigeC
pushed a commit
to SeigeC/golangci-lint
that referenced
this pull request
Apr 4, 2023
…golangci#3207) Co-authored-by: Fernandez Ludovic <ldez@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Relates to an upstream dependency
go
Pull requests that update Go code
linter: update version
Update version of linter
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps github.com/nishanths/exhaustive from 0.8.1 to 0.8.3.
Commits
ce95ec2
fix flag typo in docs64bde7e
replace '-maps' flag with '-check=switch,map' flagdba24e6
-maps flag to enable checking maps (#50)fad1089
validate map keys the same way as switch cases (#48)7935df2
add more tests for ignore-comment (#47)d513b10
use AST order to report missing names (#44)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)