Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wsl: fix force-err-cuddling flag #3407

Merged
merged 1 commit into from
Dec 12, 2022
Merged

wsl: fix force-err-cuddling flag #3407

merged 1 commit into from
Dec 12, 2022

Conversation

gandarez
Copy link
Contributor

@gandarez gandarez commented Dec 8, 2022

According to documentation enforce is misspelled for force-err-cuddling flag. It also fix the configuration assignment when creating a new WSL linter.

@boring-cyborg
Copy link

boring-cyborg bot commented Dec 8, 2022

Hey, thank you for opening your first Pull Request !

@CLAassistant
Copy link

CLAassistant commented Dec 8, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@bombsimon bombsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gandarez
Copy link
Contributor Author

Any chance to get it merged and released soon?

@ldez
Copy link
Member

ldez commented Dec 12, 2022

We have a problem with Netlify (I'm trying to fix that) so as your PR is related to the doc, we will not merge it now.

@gandarez
Copy link
Contributor Author

We have a problem with Netlify (I'm trying to fix that) so as your PR is related to the doc, we will not merge it now.

It's not related to documentation, it's a bug where some settings can't be applied to WSL. Is that a doc issue?

@ldez
Copy link
Member

ldez commented Dec 12, 2022

.golangci.reference.yml is a part of the doc

@ldez ldez enabled auto-merge (squash) December 12, 2022 17:48
@ldez ldez merged commit 0cc3585 into golangci:master Dec 12, 2022
@ldez ldez added the linter: update Update the linter implementation inside golangci-lint label Feb 5, 2023
SeigeC pushed a commit to SeigeC/golangci-lint that referenced this pull request Apr 4, 2023
@ldez ldez added this to the v1.51 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linter: update Update the linter implementation inside golangci-lint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants