Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unparam: bump to HEAD #3452

Merged
merged 1 commit into from
Jan 4, 2023
Merged

unparam: bump to HEAD #3452

merged 1 commit into from
Jan 4, 2023

Conversation

mgabeler-lee-6rs
Copy link
Contributor

@mgabeler-lee-6rs mgabeler-lee-6rs commented Jan 3, 2023 •
edited by ldez

mvdan/unparam@dc49ffe...7455f1a

Fixes #3426 (again)

  • The original fix to unparam was incomplete, this takes in the followup fix.

Follow-up to #3429

This update is done by hand because dependabot is not able to update non-semver dependency.

@boring-cyborg
Copy link

boring-cyborg bot commented Jan 3, 2023

Hey, thank you for opening your first Pull Request !

@CLAassistant
Copy link

CLAassistant commented Jan 3, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@ldez ldez added dependencies Relates to an upstream dependency linter: update version Update version of linter go Pull requests that update Go code labels Jan 3, 2023
@ldez ldez changed the title unparam: bump to HEAD (2022-12-23) unparam: bump to HEAD Jan 3, 2023
ldez
ldez approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit 271a55d into golangci:master Jan 4, 2023
@mgabeler-lee-6rs mgabeler-lee-6rs deleted the fix/update-unparam-again branch January 17, 2023 23:15
SeigeC pushed a commit to SeigeC/golangci-lint that referenced this pull request Apr 4, 2023
@mgabeler-lee-6rs @SeigeC
unparam: bump to HEAD (golangci#3452)
faf4297
@ldez ldez added this to the v1.51 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
dependencies Relates to an upstream dependency go Pull requests that update Go code linter: update version Update version of linter
Projects
None yet
Milestone
v1.51
Development

Successfully merging this pull request may close these issues.

Unparam broken with generics since x/tools update to v0.4.0
3 participants
@mgabeler-lee-6rs @CLAassistant @ldez