Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: check only changed files in pre-commit hook #3521

Merged
merged 1 commit into from
Mar 6, 2023
Merged

feat: check only changed files in pre-commit hook #3521

merged 1 commit into from
Mar 6, 2023

Conversation

davidjb
Copy link
Contributor

@davidjb davidjb commented Jan 30, 2023 •
edited by ldez
Loading

Fixes #1245
by passing filenames from pre-commit to golangci-lint run (which supports this since that issue was originally opened) and when used with --new-from-rev HEAD allows for partial commit support.

@davidjb
fix: check only changed files in pre-commit hook
77cc7d1 
Fixes golangci#1245 by passing filenames from pre-commit to `golangci-lint run` and when used with `--new-from-rev HEAD` allows for partial commit support.
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 30, 2023

Hey, thank you for opening your first Pull Request !

@CLAassistant
Copy link

CLAassistant commented Jan 30, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ldez ldez changed the title fix: check only changed files in pre-commit hook feat: check only changed files in pre-commit hook Jan 30, 2023
@ldez ldez added the enhancement New feature or improvement label Mar 6, 2023
ldez
ldez approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit 985efcc into golangci:master Mar 6, 2023
@gnuletik
Copy link
Contributor

gnuletik commented Mar 6, 2023

When copying this config locally and running pre-commit run --all-files, I get the following errors from linters:

ERRO [linters_context] typechecking error: named files must all be in one directory; have some/pkg and another/pkg
ERRO [linters_context] typechecking error: named files must all be in one directory; have my/pkg and some/other/pkg

And

failed executing command with error parallel golangci-lint is running

@jasonphi jasonphi mentioned this pull request Mar 22, 2023
Closed
4 tasks
SeigeC pushed a commit to SeigeC/golangci-lint that referenced this pull request Apr 4, 2023
@davidjb @SeigeC
feat: check only changed files in pre-commit hook (golangci#3521)
0dd52a1
@hanzo hanzo mentioned this pull request Aug 29, 2023
Merged
@ldez ldez added this to the v1.52 milestone Mar 6, 2024
@alexandear alexandear mentioned this pull request Mar 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area: pre-commit enhancement New feature or improvement
Projects
None yet
Milestone
v1.52
Development

Successfully merging this pull request may close these issues.

pre-commit hook runs on all files instead of just changed files in the repo
4 participants
@davidjb @CLAassistant @gnuletik @ldez