Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lll: skip go command #3572

Merged
merged 5 commits into from
Feb 22, 2023
Merged

lll: skip go command #3572

merged 5 commits into from
Feb 22, 2023

Conversation

black-06
Copy link
Contributor

@black-06 black-06 commented Feb 7, 2023

Skip go command because we can't add //nolint to the go command line.

@boring-cyborg
Copy link

boring-cyborg bot commented Feb 7, 2023

Hey, thank you for opening your first Pull Request !

@ldez ldez added the linter: update Update the linter implementation inside golangci-lint label Feb 7, 2023
@ldez ldez self-requested a review February 7, 2023 08:14
ldez
ldez requested changes Feb 22, 2023
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can just exclude all comments with the go directive prefix.

pkg/golinters/lll.go Outdated Show resolved Hide resolved
pkg/golinters/lll.go Outdated Show resolved Hide resolved
black-06 and others added 3 commits February 22, 2023 08:47
@black-06 @ldez
exclude all comments with the go directive prefix
ef6df55 
Co-authored-by: Ludovic Fernandez <ldez@users.noreply.github.com>
@black-06 @ldez
exclude all comments with the go directive prefix
60267bc 
Co-authored-by: Ludovic Fernandez <ldez@users.noreply.github.com>
@black-06
Merge branch 'master' into lll-skip-go-command
90924b8
@ldez ldez added the bug Something isn't working label Feb 22, 2023
ldez
ldez approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit 610a2bd into golangci:master Feb 22, 2023
@Antonboom Antonboom mentioned this pull request Mar 14, 2023
Open
SeigeC pushed a commit to SeigeC/golangci-lint that referenced this pull request Apr 4, 2023
@black-06 @ldez @SeigeC
lll: skip go command (golangci#3572)
da9e3cb 
Co-authored-by: Ludovic Fernandez <ldez@users.noreply.github.com>
@ldez ldez added this to the v1.52 milestone Mar 6, 2024
@alexandear alexandear mentioned this pull request Mar 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
bug Something isn't working linter: update Update the linter implementation inside golangci-lint
Projects
None yet
Milestone
v1.52
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@black-06 @ldez