fix: combination of --fix and --path-prefix #3700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is an alternative to #3626. |
This was referenced Mar 16, 2023
pohly
commented
Mar 17, 2023
pohly
force-pushed
the
fixer-path-handling
branch
from
cfacb9f
to
328b2b5
Compare
ldez
changed the title
pohly
force-pushed
the
fixer-path-handling
branch
from
328b2b5
to
b8ea93c
Compare
|
Rebased after PR #3571 was merged. |
pohly
force-pushed
the
fixer-path-handling
branch
from
b8ea93c
to
9639df6
Compare
This combination used to fail because the fixer was executed after the path
prefixer. Then the file paths that it processed didn't match the current
working directory, leading to:
ERRO Failed to fix issues in file test/fix_sample/main.go: failed to get file bytes for test/fix_sample/main.go: can't read file test/fix_sample/main.go: open test/fix_sample/main.go: no such file or directory
Making the fixer a normal processor and moving it before the path prefixer
avoids this problem.
The combination with --path gets tested for the first test case. This is arbitrary. It could also be tested for all of them, but then each test would have to run twice (with and without).
ldez
force-pushed
the
fixer-path-handling
branch
from
5ab5f7b
to
c5a1743
Compare
SeigeC
pushed a commit
to SeigeC/golangci-lint
that referenced
this pull request
Apr 4, 2023
Co-authored-by: Fernandez Ludovic <ldez@users.noreply.github.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This combination used to fail because the fixer was executed after the path prefixer.
Then the file paths that it processed didn't match the current working directory, leading to:
Making the fixer a normal processor and moving it before the path prefixed avoids this problem.
Related to #2293 and #3626