fix(pre-commit): require_serial & pass_filenames

[gnuletik]

In order to avoid the following error when running pre-commit

Error: parallel golangci-lint is running

We need to force golangci-lint to run in sequence.

Fixes #3715

[boring-cyborg]

Hey, thank you for opening your first Pull Request !

[CLAassistant]

All committers have signed the CLA.

[ldez]

LGTM

[macnibblet]

@gnuletik @ldez To me after this has been merged the golangci-lint is now running against the entire code base instead of just the files changed when I commit. Are you experiencing the same issue?

[gnuletik]

@macnibblet I just tried to:

• Update a go file in my index (so golangci-lint is not skipped)
• create a file with an error like bad.go
• git add my updated go file in my index
• commit

And yes, pre-commit is run on bad.go event if it should not.

I did not find a config to make it work properly.
If you set pass_filename: true, you may get:

ERRO [linters_context] typechecking error: named files must all be in one directory; have [some_package] and [another_package]

[macnibblet]

Hmm, I have never experienced that issue you are referring to. But can i set pass_filename as one of the args in my pre-commit config?

[gnuletik]

Hmm, I have never experienced that issue you are referring to. But can i set pass_filename as one of the args in my pre-commit config?

Yes you can set pass_filename: true in your local config but you will get the above issue if you have multiple go packages.

[macnibblet]

@gnuletik so i tried setting the pass_filename: true but it works perfectly fine for us because all our source code is in a src folder

We have a mono repository that looks like this, so maybe we should update the documentation to explain the issue more clearly.

src/
  - authentication
  -- internal/
  -- cmd/

  - users
  -- internal/
  -- cmd/

[gnuletik]

@macnibblet even if all your source files are in a src directory, you may still have the issue because you have multiple go packages (e.g. users/cmd and authentication/cmd).

However, the reproduction may depends on your golangci-lint config and the files you include in your git commit.

See also #3200