Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: explain typecheck and remove it from the linter list #3929

Merged
merged 3 commits into from Jun 29, 2023
Merged

feat: explain typecheck and remove it from the linter list #3929

merged 3 commits into from Jun 29, 2023

Conversation

ldez
Copy link
Member

@ldez ldez commented Jun 28, 2023 •
edited

  • add a documentation section about typecheck
  • remove typecheck from the lists of linters (doc, help, etc.)
  • enforce the activation of typecheck

Fixes #3460

@ldez ldez added the enhancement New feature or improvement label Jun 28, 2023
@ldez ldez requested a review from bombsimon June 28, 2023 14:06
@ldez ldez force-pushed the feat/typecheck-doc branch 2 times, most recently from c67349a to a165b7c Compare June 28, 2023 14:11
@ldez ldez changed the title feat :explain typecheck and remove it from the linter list feat: explain typecheck and remove it from the linter list Jun 28, 2023
@ldez ldez mentioned this pull request Jun 28, 2023
Closed
4 tasks
@ldez ldez force-pushed the feat/typecheck-doc branch 5 times, most recently from 61adb83 to becee2f Compare June 28, 2023 15:47
@ldez
Copy link
Member Author

ldez commented Jun 28, 2023 •
edited

Something is weird: some tests don't fail locally but fail on the CI, and the failures on the CI are right.
There is something that I don't understand 🤔

Anyway, I fixed all the tests.

bombsimon
bombsimon approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@bombsimon bombsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Should we add a link to this section in the issue template so we increase the chances of people finding this before creating an issue?

docs/src/docs/usage/faq.mdx Outdated Show resolved Hide resolved
@ldez
Copy link
Member Author

ldez commented Jun 29, 2023

so we increase the chances of people finding this before creating an issue?

I will do that inside PR #3930 after the merge of this PR.

bombsimon
bombsimon approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@bombsimon bombsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bombsimon bombsimon mentioned this pull request Jun 29, 2023
Merged
@ldez ldez merged commit 79c78d6 into golangci:master Jun 29, 2023
16 checks passed
@ldez ldez deleted the feat/typecheck-doc branch June 29, 2023 20:41
@ldez ldez added this to the v1.54 milestone Mar 6, 2024
@alexandear alexandear mentioned this pull request Mar 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bombsimon bombsimon bombsimon approved these changes

Assignees
No one assigned
Labels
enhancement New feature or improvement
Projects
None yet
Milestone
v1.54
Development

Successfully merging this pull request may close these issues.

Improve documentation about typecheck
2 participants
@ldez @bombsimon