plugin: temporarily hide warning about using plugins using the old API #4002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
changed the title
bombsimon
reviewed
Aug 10, 2023
There was a problem hiding this comment.
I agree with your comment (which I also wrote in the ticket). I don't get how waiting until the next release to display the log message would make any difference? It will just give the user less time to fix, or golangci-lint one extra release before fully deprecating/removing (if ever?).
ldez
force-pushed
the
fix/plugin-remove-warn
branch
from
b8fa47f
to
105da96
Compare
ldez
changed the title
|
I updated to PR based on #4001 (comment) @bombsimon WDYT? |
bombsimon
approved these changes
Aug 11, 2023
Co-authored-by: Simon Sawert <simon@sawert.se>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4001
I will create a PR after the merge of this one to restore the log.