Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] add vulncheck as linter #4074

Closed
wants to merge 13 commits into from
Closed

Conversation

rodrigc
Copy link

@rodrigc rodrigc commented Sep 8, 2023

Related to #3094

Continuing the work original submitted in #3199

@boring-cyborg
Copy link

boring-cyborg bot commented Sep 8, 2023

Hey, thank you for opening your first Pull Request !

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ luxifer
❌ rodrigc
You have signed the CLA already but the status is still pending? Let us recheck it.

@rodrigc rodrigc changed the title add vulncheck as linter [wip] add vulncheck as linter Sep 8, 2023
@rodrigc
Copy link
Author

rodrigc commented Sep 8, 2023

@luxifer Not sure if you are interested in collaborating on this PR to make this "production-ready", but I took your original branch and tried updating it.

@ldez ldez closed this Sep 8, 2023
@ldez ldez added the declined label Sep 8, 2023
@ldez
Copy link
Member

ldez commented Sep 8, 2023

It's useless to open a PR when I close the other one about the same topic and with the same content.
The discussions are inside issue #3094, and the current status of this proposal is clear.
You can disagree, and do it on the issue but forcing things by opening a PR is a really bad way to interact.

@golangci golangci locked as resolved and limited conversation to collaborators Sep 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants