gocritic: support of enable-all and disable-all options

[Antonboom]

Closes #4108

[ldez]

There are a lot of changes not exactly related to the feature.
I can understand why those changes but it's complex to review the PR.

[Antonboom]

@ldez thank u for review
I dropped answers in comments above

but it's complex to review the PR.

Yes, it's true :(

I wasted a lot of time to review & test it too, but to be honest the actual state is easier and simpler to review – I tried to simplify code and make it more robust and strict

I was hoping that this feature would look good in the upcoming release.

What your proposal? Next steps?

I see it as:

1. Request review from @alexandear, @SVilgelm, @bombsimon
2. Test (independently from me) this feature on real project with different config combinations.
3. Merge it and to be ready to ASAP patches if some issues found.

[ldez]

What your proposal? Next steps?

My comment was just to say that the review will not be quick.

[ldez]

Instead of creating methods like isLowerCasedCheckEnabled, IsCheckEnabled, isKnownLowerCasedCheck, isKnownCheck, etc. I propose use a type:

type goCriticMap[T any] map[string]T

func (f goCriticMap[T]) has(name string) bool {
	_, ok := f[name]
	return ok
}

type goCriticSettingsWrapper struct {
	*config.GoCriticSettings

	logger logutils.Log

	allCheckers []*gocriticlinter.CheckerInfo

	allChecks             goCriticMap[struct{}]
	allChecksByTag        goCriticMap[[]string]
	allTagsSorted         []string
	inferredEnabledChecks goCriticMap[struct{}]

	// *LowerCased* fields are used for GoCriticSettings.SettingsPerCheck validation only.

	allChecksLowerCased             goCriticMap[struct{}]
	inferredEnabledLowerCasedChecks goCriticMap[struct{}]
}

// ...

func (s *goCriticSettingsWrapper) validateCheckerTags() error {
	for _, tag := range s.EnabledTags {
		if !s.allChecksByTag.has(tag) {
			return fmt.Errorf("enabled tag %q doesn't exist, see %s's documentation", tag, goCriticName)
		}
	}

	for _, tag := range s.DisabledTags {
		if !s.allChecksByTag.has(tag) {
			return fmt.Errorf("disabled tag %q doesn't exist, see %s's documentation", tag, goCriticName)
		}
	}

	return nil
}

[Antonboom]

@ldez , hi

thank you for review

I propose use a type

cool idea! simplified.

the type is candidate to be a more common type, but I left goCritic-prefix

• so as not to generalize ahead of time
• to isolate linters from each other

P.S. God bless the new tests :D

[ldez]

LGTM