Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rule severity is required #4469

Merged
merged 3 commits into from
Mar 9, 2024
Merged

Conversation

ldez
Copy link
Member

@ldez ldez commented Mar 8, 2024

severity:
  default-severity: error
  rules:
    - linters:
        - lll
      severity: warning

The default-severity applies to all linters, the rules are optional.

Then a rule is useful only if defining a severity.

@ldez ldez added the bug Something isn't working label Mar 8, 2024
@ldez ldez added this to the next milestone Mar 8, 2024
@ldez ldez changed the title fix: rule severity is required and different than the default one fix: rule severity is required and must be different than the default one Mar 8, 2024
@ldez ldez force-pushed the fix/severity-rule-required branch from 8aac3d1 to 35bf422 Compare March 9, 2024 02:45
pkg/config/severity.go Outdated Show resolved Hide resolved
@ldez ldez changed the title fix: rule severity is required and must be different than the default one fix: rule severity is required Mar 9, 2024
@ldez ldez merged commit 797d3bb into golangci:master Mar 9, 2024
12 checks passed
@ldez ldez deleted the fix/severity-rule-required branch March 9, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: severity bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants