Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Sarif output #4723

Merged

Conversation

SophisticaSean
Copy link
Contributor

@SophisticaSean SophisticaSean commented May 16, 2024

This work supports exporting Sarif file format. It's a common enough format and I figured I'd help out by adding it. :)

Sarif documentation:
https://github.com/microsoft/sarif-tutorials/blob/main/docs/2-Basics.md#results
https://docs.oasis-open.org/sarif/sarif/v2.1.0/cs01/schemas/sarif-external-property-file-schema-2.1.0.json

fixes #2866

Copy link

boring-cyborg bot commented May 16, 2024

Hey, thank you for opening your first Pull Request !

@CLAassistant
Copy link

CLAassistant commented May 16, 2024

CLA assistant check
All committers have signed the CLA.

@ldez ldez self-requested a review May 16, 2024 11:30
@ldez ldez added the enhancement New feature or improvement label May 16, 2024
@ldez ldez added the area: output Related to issue output label May 16, 2024
@ldez ldez modified the milestone: next May 16, 2024
pkg/printers/sarif.go Outdated Show resolved Hide resolved
pkg/printers/sarif.go Outdated Show resolved Hide resolved
ldez and others added 3 commits May 17, 2024 15:30
Co-authored-by: Oleksandr Redko <oleksandr.red+github@gmail.com>
@SophisticaSean
Copy link
Contributor Author

Wow thanks so much for the quick fixes and reviews. Y'all are impressive!

@ldez ldez added this to the next milestone May 19, 2024
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit 4f5251d into golangci:master May 19, 2024
13 checks passed
@ZyanKLee
Copy link

Thanks @SophisticaSean and all the reviewers

@ldez ldez modified the milestones: next, v1.59 May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: output Related to issue output enhancement New feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

idea: add sarif output format
5 participants