Added "bodyclose" support #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds full support for bodyclose linter (https://github.com/timakin/bodyclose), which checks if an `http.Body` element is correctly closed after usage. Since it can be used via `go/analysis', I followed the `govet' example as suggested by https://github.com/golangci/golangci-lint/wiki/How-to-add-a-custom-linter. This commit is fully tested, and contains a (flawed) test program which calls `http.Get()' on `https://google.com' and does not closes its corresponding `http.Body'.
|
|
|
Uhm, I do run |
|
@gsora - Perhaps you're using an older version of goimports? It could possibly be the import order. Typically I think goimports does standard library imports first. |
|
I checked and I'm using the latest version of |
|
thank you for this contribution! it has some issues and I will fix them myself because it's my fault that it's being merged too long |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds full support for bodyclose linter
(https://github.com/timakin/bodyclose), which checks if an
http.Bodyelement is correctly closed after usage.
Since it can be used via
go/analysis, I followed thegovetexampleas suggested by https://github.com/golangci/golangci-lint/wiki/How-to-add-a-custom-linter.
This commit is fully tested, and contains a (flawed) test program which
calls
http.Get()onhttps://google.comand does not closes itscorresponding
http.Body.