This repository has been archived by the owner on Jun 2, 2023. It is now read-only.
just for testing purposes #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangci
commented
May 13, 2018
app/analyze/executors/shell.go
Outdated
| @@ -67,10 +67,10 @@ func trackMemoryEveryNSeconds(ctx context.Context, name string, pid int) { | |||
| } | |||
| } | |||
|
|
|||
| func (s shell) wait(ctx context.Context, name string, pid int, outReader io.ReadCloser) []string { | |||
| func (s shell) wait(ctx context.Context, name string, childPid int, outReader io.ReadCloser) []string { | |||
There was a problem hiding this comment.
outReader can be io.Reader
app/analyze/state/api_storage.go
Outdated
| @@ -28,7 +28,9 @@ func getHTTPClient() *http.Client { | |||
| } | |||
|
|
|||
| tr := &http.Transport{ | |||
| TLSClientConfig: &tls.Config{InsecureSkipVerify: true}, | |||
| TLSClientConfig: &tls.Config{ | |||
| InsecureSkipVerify: true, | |||
There was a problem hiding this comment.
G402: TLS InsecureSkipVerify set true.
golangci
force-pushed
the
feature/test-golangci-lint
branch
from
c298973
to
488ad3c
Compare
golangci
commented
May 13, 2018
app/analytics/track.go
Outdated
| UserId: userID, | ||
| EventType: string(eventName), | ||
| EventProperties: eventProps, | ||
| }) | ||
| } | ||
| ac.Publish(ev) |
There was a problem hiding this comment.
Error return value of ac.Publish is not checked
app/analyze/state/api_storage.go
Outdated
| @@ -28,7 +28,9 @@ func getHTTPClient() *http.Client { | |||
| } | |||
|
|
|||
| tr := &http.Transport{ | |||
| TLSClientConfig: &tls.Config{InsecureSkipVerify: true}, | |||
| TLSClientConfig: &tls.Config{ | |||
| InsecureSkipVerify: true, | |||
There was a problem hiding this comment.
G402: TLS InsecureSkipVerify set true.
app/analyze/executors/shell.go
Outdated
| @@ -67,10 +67,10 @@ func trackMemoryEveryNSeconds(ctx context.Context, name string, pid int) { | |||
| } | |||
| } | |||
|
|
|||
| func (s shell) wait(ctx context.Context, name string, pid int, outReader io.ReadCloser) []string { | |||
| func (s shell) wait(ctx context.Context, name string, childPid int, outReader io.ReadCloser) []string { | |||
There was a problem hiding this comment.
outReader can be io.Reader
golangci
commented
May 13, 2018
app/analyze/executors/shell.go
Outdated
| @@ -67,10 +67,10 @@ func trackMemoryEveryNSeconds(ctx context.Context, name string, pid int) { | |||
| } | |||
| } | |||
|
|
|||
| func (s shell) wait(ctx context.Context, name string, pid int, outReader io.ReadCloser) []string { | |||
| func (s shell) wait(ctx context.Context, name string, childPid int, outReader io.ReadCloser) []string { | |||
There was a problem hiding this comment.
outReader can be io.Reader
app/analyze/state/api_storage.go
Outdated
| @@ -28,7 +28,9 @@ func getHTTPClient() *http.Client { | |||
| } | |||
|
|
|||
| tr := &http.Transport{ | |||
| TLSClientConfig: &tls.Config{InsecureSkipVerify: true}, | |||
| TLSClientConfig: &tls.Config{ | |||
| InsecureSkipVerify: true, | |||
There was a problem hiding this comment.
G402: TLS InsecureSkipVerify set true.
app/analytics/track.go
Outdated
| UserId: userID, | ||
| EventType: string(eventName), | ||
| EventProperties: eventProps, | ||
| }) | ||
| } | ||
| ac.Publish(ev) |
There was a problem hiding this comment.
Error return value of ac.Publish is not checked
golangci
commented
May 13, 2018
app/analytics/track.go
Outdated
| UserId: userID, | ||
| EventType: string(eventName), | ||
| EventProperties: eventProps, | ||
| }) | ||
| } | ||
| ac.Publish(ev) |
There was a problem hiding this comment.
Error return value of ac.Publish is not checked
app/analyze/state/api_storage.go
Outdated
| @@ -28,7 +28,9 @@ func getHTTPClient() *http.Client { | |||
| } | |||
|
|
|||
| tr := &http.Transport{ | |||
| TLSClientConfig: &tls.Config{InsecureSkipVerify: true}, | |||
| TLSClientConfig: &tls.Config{ | |||
| InsecureSkipVerify: true, | |||
There was a problem hiding this comment.
G402: TLS InsecureSkipVerify set true.
app/analyze/executors/shell.go
Outdated
| @@ -67,10 +67,10 @@ func trackMemoryEveryNSeconds(ctx context.Context, name string, pid int) { | |||
| } | |||
| } | |||
|
|
|||
| func (s shell) wait(ctx context.Context, name string, pid int, outReader io.ReadCloser) []string { | |||
| func (s shell) wait(ctx context.Context, name string, childPid int, outReader io.ReadCloser) []string { | |||
There was a problem hiding this comment.
outReader can be io.Reader
golangci
force-pushed
the
feature/test-golangci-lint
branch
from
488ad3c
to
c6d88cd
Compare
golangci
force-pushed
the
feature/test-golangci-lint
branch
from
c6d88cd
to
5d119ec
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.