no comments/output on PR

[adamdecaf]

Hi, I'm trying this out on a PR of mine: adamdecaf/cert-manage#195

The problem is I'm not seeing any output. If I run golangci-lint run locally I see some errors. I'm also seeing output if I disable/enable the checks as what's on the PR.

$ golangci-lint run --enable-all --disable golint,interfacer,gocyclo,gofmt,goimports,maligned,megacheck
Run this tool in cloud on every github pull request in https://golangci.com for free (public repos)
main.go:151:10: Error return value of `fs.Parse` is not checked (errcheck)
	fs.Parse(os.Args[1:])
	        ^
main.go:156:10: Error return value of `fs.Parse` is not checked (errcheck)
	fs.Parse(os.Args[2:]) // reparse
	        ^
pkg/certutil/x509.go:26:10: Error return value of `ss.Write` is not checked (errcheck)
	ss.Write(c.Raw)
	        ^
pkg/certutil/x509.go:32:10: Error return value of `ss.Write` is not checked (errcheck)
	ss.Write(c.Raw)
	        ^
pkg/cmd/gen_whitelist.go:144:9: Error return value of `w.Flush` is not checked (errcheck)
	w.Flush()
	       ^
pkg/ui/server/server.go:73:18: Error return value of `io.WriteString` is not checked (errcheck)
			io.WriteString(w, fmt.Sprintf("ERROR: %v", err))
			              ^
pkg/ui/web.go:83:17: Error return value of `io.WriteString` is not checked (errcheck)
		io.WriteString(w, fmt.Sprintf("ERROR: %v", err))
		              ^
pkg/ui/web.go:94:18: Error return value of `io.WriteString` is not checked (errcheck)
			io.WriteString(w, fmt.Sprintf("Unknown format %s", cfg.Format))
			              ^
pkg/ui/web.go:121:12: Error return value of `w1.Flush` is not checked (errcheck)
			w1.Flush()
			        ^
pkg/ui/web.go:128:8: Error return value of `write` is not checked (errcheck)
		write(w, list, struct {
		     ^
pkg/ui/web.go:133:8: Error return value of `write` is not checked (errcheck)
		write(w, footer, nil)
		     ^
test/main_test.go:31:20: unnecessary conversion (unconvert)
	fmt.Println(string(out))
	                  ^
pkg/whitelist/gen/firefox.go:48:31: unnecessary conversion (unconvert)
			VisistedAt: time.Unix(int64(when/1e6), 0).UTC(), // throw away nsec
			                           ^
pkg/whitelist/gen/gen.go:35:2: `client` is unused (varcheck)
	client = httputil.New()
	^

[adamdecaf]

I did git push -f a couple times on this PR. Perhaps that's the problem? The GolangCI bot runs and finishes pretty quickly.

[golangci]

hi! thank you for using and reporting, sorry, that our behavior isn't obvious.
golangci.com checks and comments only changed in the pull request code, not all code. We'are planning to release status pages to see all issues in code, not only changed.
For demonstration I've changed every line in your repo by appending the space in the end of line (find pkg -name "*.go" -type f -print0 | xargs -0 perl -i.bak -pe 's/^(.*)$/$1 /g') and opened a PR

[adamdecaf]

golangci.com checks and comments only changed in the pull request code, not all code.

Ahh. That makes sense. Thanks for the tip!