Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What happens when 500 prank ends? #32

Open
christian-posta opened this issue Apr 8, 2019 · 2 comments
Open

What happens when 500 prank ends? #32

christian-posta opened this issue Apr 8, 2019 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@christian-posta
Copy link

christian-posta commented Apr 8, 2019

Looks like the route is removed and replaced for a 500 prank. When the prank ends, what is supposed to happen to the original route? It gets removed:
https://github.com/i0natan/node-chaos-monkey/blob/master/pranks/500-error-on-route.js#L12

In my tests, when the prank is complete, I get 404 for that route

@goldbergyoni goldbergyoni added the bug Something isn't working label Apr 10, 2019
@goldbergyoni goldbergyoni self-assigned this Apr 10, 2019
@goldbergyoni
Copy link
Owner

Yes, seems like a bug. I'm on it unless you're willing to contribute the fix :)

p.s. side question - how did you find the experience of working with the monkey? did you work through the UI?

@christian-posta
Copy link
Author

So I used the REST API from both master and 0.7.1.
I'm trying to get basic fault injection working (throw 500s, delay responses etc) to work. After some hacks in remove-express-route I am able to get chaos-monkey to work with 500s but only the timed schedules (one-time schedule doesn't actually do one time). I didn't get the UI up. Wonder if the pranks would be better implemented as middleware instead of replacing the route? unless you can layer the route in ahead of the real route without removing it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants