Initial support for wide ncurses(multibyte output) #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shtirlic
force-pushed
the
widecurses
branch
2 times, most recently
from
56f5d18
to
13b0056
Compare
vitaliy-aksyonov
requested changes
May 31, 2024
shtirlic
force-pushed
the
widecurses
branch
3 times, most recently
from
d5231c6
to
817b907
Compare
vitaliy-aksyonov
approved these changes
Jun 3, 2024
|
What about codacy warnings? Is there a way to move variables declaration under the same conditions as their usage? |
I'd just move it under |
* vsave update to row scan, support wide chars * vrestore update to row restore, supports wide chars Basic ncurses ouput(scrolling) should be smoother since now we are restoring and filling buffers by row instead of one by one char
|
Updated for codacy |
vitaliy-aksyonov
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic ncurses ouput(scrolling) should be smoother since now we are restoring and filling buffers by row instead of one by one char