Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Transitions #463

Closed
hbulens opened this issue Aug 27, 2018 · 0 comments
Closed

CSS Transitions #463

hbulens opened this issue Aug 27, 2018 · 0 comments
Labels
Backlog Larger features which require a refactoring More information needed More information is needed on the issue before further progressing

Comments

@hbulens
Copy link

hbulens commented Aug 27, 2018

Is there a clean way to support CSS transitions as shown in this pen? I had to modify the _$maximiseItem function to make this work:

.lm_stack {
  transition: width .5s;
}
    
_$maximiseItem: function (contentItem) {
        if (this._maximisedItem !== null) {
            this._$minimiseItem(this._maximisedItem);
        }
        this._maximisedItem = contentItem;
        this._maximisedItem.addId('__glMaximised');
        contentItem.element.addClass('lm_maximised');
        contentItem.element.after(this._maximisePlaceholder);
        this.root.element.prepend(contentItem.element);

        var me = this;
        contentItem.element.width(this.container.width());
        contentItem.element.height(this.container.height());

        setTimeout(function () {
            contentItem.callDownwards('setSize');                
        }, 500);
}

Of course this is not how it should work but at least it gives a fluent motion when maximizing and minimizing the panes. Any idea on how to call the contentItem.callDownwards('setSize') when the animation is done?

@ButchMonkey ButchMonkey added the kind/feature Small fixes and features label Mar 19, 2019
@martin31821 martin31821 added Backlog Larger features which require a refactoring More information needed More information is needed on the issue before further progressing and removed kind/feature Small fixes and features labels Jan 30, 2020
@pbklink pbklink closed this as completed Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backlog Larger features which require a refactoring More information needed More information is needed on the issue before further progressing
Projects
None yet
Development

No branches or pull requests

4 participants