New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(container): allow setSize to work with widths and heights #37

Merged
merged 1 commit into from Feb 15, 2015

Conversation

Projects
None yet
2 participants
@steelsojka
Contributor

steelsojka commented Feb 14, 2015

Currently the setSize method on containers only works with heights but
accepts 2 parameter width, height. If the container is part of a row
the width is used to resize the widths of all content items. If the
container is part of a column the height is used to resize the height of
all content items.

fix(container): allow setSize to work with widths and heights
Currently the `setSize` method on containers only works with heights but
accepts 2 parameter `width, height`. If the container is part of a row
the width is used to resize the widths of all content items. If the
container is part of a column the height is used to resize the height of
all content items.

deepstreamIO pushed a commit that referenced this pull request Feb 15, 2015

hoxton-one
Merge pull request #37 from steelsojka/container_resizing
fix(container): allow setSize to work with widths and heights

@deepstreamIO deepstreamIO merged commit ca9be36 into golden-layout:master Feb 15, 2015

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Feb 15, 2015

Contributor

Hi,
many thanks for the fix. I'm surprised that this issue hadn't come up earlier, since pretty grave.

Contributor

ghost commented Feb 15, 2015

Hi,
many thanks for the fix. I'm surprised that this issue hadn't come up earlier, since pretty grave.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment