Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination Doesn't Play with Filtering #12

Open
vicmaine opened this issue May 20, 2012 · 1 comment
Open

Pagination Doesn't Play with Filtering #12

vicmaine opened this issue May 20, 2012 · 1 comment

Comments

@vicmaine
Copy link

Pagination only seems to work if you haven't filtered

THIS WORKS:
http://www.website.com/reclinks/page/2

THIS DOESN'T:
http://www.website.com/reclinks/?sort=newest/page/2

It would be nice if those "filters" could actually be static pages anyway.

IE:
http://www.website.com/reclinks/newest_posts
http://www.website.com/reclinks/popular_today
http://www.website.com/reclinks/popular_this_week
http://www.website.com/reclinks/popular_all_time

Having static pages for these "filters" (which you now just have using what appears to be the standard built-in wordpress filtering calls) would be a lot better because each of those individual pages could then build up their own PageRank the way inbound.org's do. For example; their front page is a PR5, but their http://inbound.org/incoming/ is a PR3 all on its own (the ability for those individual-pages to have their own PR is incredibly valuable because that means that the 25 newest submissions are getting PR juice too, not just the 25 on the front page (that's much much more incentive for people to submit new content (they get a PR3 just for posting, without even getting a single vote yet, that's awesome).

So on a related topic: Not sure if you've noticed this but inbound.org's site appears to be amazingly similar to your plugin. I talked to their developer and he said they were actually using a customized version of the Nominate theme (http://prothemedesign.com/themes/nominate-for-wordpress/) but I still say it looks a hell of a lot more like yours than theirs. Some obvious ones are that they have 25 posts per page just like yours, they use the word karma like yours, and most of all, all their listing links are IDENTICAL to your votebox() even the linear order of those links in your votebox() are the same.

Anyway, hope that static-pages thing might be something you could implement INSTEAD OF trying to fix pagination ith filtering problem.

Am I driving you nuts yet? I played around with that Nominate theme earlier tonight by the way, and I'm definitely not a big fan, yours is so much easier to customize, well worth waiting for.

thanks brother

@goldenapples
Copy link
Owner

Some good points.

I don't know if its 100% true or not that pages which include guery string variables are not indexed the same way by Google, etc. - I think the reality of how Google guesses at canonical urls when none are specified, or flows pagerank between links, is a lot more complicated. But... thats not my area of expertise at all.

I think as a general rule, it makes more sense to me for two different views of the same archive that only differ by their sort order be differentiated by a query string variable rather than by url path components. But I do see your point about making them static pages - that way people could, if they desired, style the "new" links page differently from the "controversial" one. And... it seems like that would be easy enough to implement.

Hadn't heard of Nominate theme before, but it looks like an interesting project. At the very least, it would be good to look into the format they use to store data, so that I can offer an import / export of data between this plugin and the Nominate theme.

goldenapples added a commit that referenced this issue May 21, 2012
Hardcodes rewrite rules for paginated archives with each of the
filtering options (hot, newest, current, score, controversial). This
partially addresses the bug in #12 (where the "next posts" link would
generate a faulty URL like 'reclinks/?sort=newest/page/2' which didn't
resolve into a proper query). Now the URL 'reclinks/newest/page/2' will
work. Still need to fix the functions which generate URLS with the
'?sort=' query string in the first place...

Also, I plan to allow the option of creating actual page stubs for each
of the sort options; just haven't figured out the best way of handling
that yet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants