Fix potential memory leak due to QNetworkReply may not deleted

goldendict · May 8, 2013 · 8a46cd8 · 8a46cd8
1 parent abf027a
commit 8a46cd8
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/webmultimediadownload.cc b/webmultimediadownload.cc
@@ -21,7 +21,7 @@ void WebMultimediaDownload::cancel()
 
 void WebMultimediaDownload::replyFinished( QNetworkReply * r )
 {
-  if ( r != reply )
+  if ( !r || r != reply )
     return; // Not our reply
 
   if ( r->error() == QNetworkReply::NoError )
@@ -39,9 +39,10 @@ void WebMultimediaDownload::replyFinished( QNetworkReply * r )
   else
     setErrorString( r->errorString() );
 
-  finish();
-
+  r->deleteLater();
   reply = NULL;
+
+  finish();
 }
 
 bool WebMultimediaDownload::isAudioUrl( QUrl const & url )