Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode html entities in Search pane's word results for malformed diction... #114

Closed

Conversation

chulai
Copy link
Member

@chulai chulai commented Jul 23, 2012

...aries. Issue #53

@Abs62 or @dragonroot can any of you review these changes? My tests showed that it fixes issue #53 but I'm not sure if there is a better way to do it or it can handle correctly all encodings.

@Abs62
Copy link
Member

Abs62 commented Jul 23, 2012

  1. Such unescaped headwords lost connection with its articles because index entries still non-unescaped. I think it needs to convert such bad words during indexing of a dictionary.
  2. I am not sure about '<' symbol. Some dictionaries have legal entries with it which can be corrupted by such conversion. Urban dictionary, for example. I think it needs only to check '&' symbol together with ';' symbol.

PS. How about QTextDocumentFragment instead of QTextDocument?

@chulai
Copy link
Member Author

chulai commented Jul 23, 2012

I will check all your suggestions. I didn't notice first point because the terms were duplicated in the dictionary. i.e. with html entities and unescaped.

@Abs62
Copy link
Member

Abs62 commented Nov 13, 2012

Modified and introduced into code.

@Abs62 Abs62 closed this Nov 13, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants