Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use patched libao in order to support OSX without copying plugins (#295) #377

Merged
merged 1 commit into from
Aug 10, 2013

Conversation

timonwong
Copy link
Member

No description provided.

@Tvangeste
Copy link
Member

@chulai Would you be able to take a look on MacOS?

@chulai
Copy link
Member

chulai commented Aug 10, 2013

Guys, these are the tests I performed:

  1. GoldenDict with ao plugin
    1.1) Copy libmacosx.so to /usr/local/lib/ao/plugins-4/libmacosx.so
    1.2) Try to play some sounds in GoldenDict with the internal player.

Outcome: Works!

  1. GoldenDict without ao plugin
    2.1) Delete libmacosx.so from /usr/local/lib/ao/plugins-4/libmacosx.so
    2.2) Try to play some sounds in GoldenDict with the internal player.

Outcome: Doesn't work. Error is "FFmpeg audio player: Cannot find usable audio output device."

  1. GoldenDict with patched lib ao (so not to use ao plugin install)
    3.1) Delete libmacosx.so from /usr/local/lib/ao/plugins-4/libmacosx.so
    3.2) Apply pull request Use patched libao in order to support OSX without copying plugins (#295) #377 with timonwong:libao_osx branch and do a full build of GoldenDict.
    3.3) Try to play some sounds in GoldenDict with the internal player.

Outcome: Works!

I ran those tests in 10.6.8 Snow Leopard, 10.7.3 Lion and Mountain Lion and I got all the same results.

Is that enough?

@Tvangeste
Copy link
Member

It works for me as well, so it seems ready to merge.

@chulai
Copy link
Member

chulai commented Aug 10, 2013

I just updated the Spanish locale. If we can merge this I'd like to build a new EA build for Mac OS X soon.

Tvangeste added a commit that referenced this pull request Aug 10, 2013
Use patched libao in order to support OSX without copying plugins (#295)
@Tvangeste Tvangeste merged commit 56830bf into goldendict:master Aug 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants