Fix for Howl's stop method (webAudio) #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous behavior has the method return immediately if sound._node.bufferSource is null, preventing the rest of the sounds in the group to be stopped.
|
Just ran into this same problem myself. I ended up swapping return with continue, but that's probably a better way of doing it. Would love to see this get released :) |
ringcrl
pushed a commit
to ringcrl/howler.js
that referenced
this pull request
Apr 21, 2019
Fix for Howl's stop method (webAudio)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous behavior has the method return immediately if sound._node.bufferSource is null, preventing the rest of the sounds in the group to be stopped.