Added [chunkhash]/[hash]/[id]/[name] support for importScripts #70

hulkish · 2017-05-01T02:13:41Z

For documentation on how this works, please see my changes to README.md.

This satisfies #60

hulkish · 2017-05-02T15:54:15Z

@goldhand hmm.. any issue with this? Was hoping to move this forward soon.

goldhand · 2017-05-02T16:13:58Z

@hulkish nope! I was away this weekend. Glancing over this just now, looks great! Will look a little more in depth today before I merge

goldhand

Looks good overall, a couple changes, mostly to the readme. Also, just to clarify, will importScripts: ['myscript.[hash].js'] still be supported or will they need to use the format importScripts: {filename: myscript.[hash].js'}` to get the legacy hash support

goldhand · 2017-05-02T16:22:11Z

README.md

+  - When importScripts array item is a `String`:
+    - Converts to object format `{ filename: '<publicPath>/my-script.js'}`
+  - When importScripts array item is an `Object`:
+    - Looks for


I think you for got finish a thought here

goldhand · 2017-05-02T16:26:49Z

README.md

@@ -1,4 +1,4 @@
-SW Precache Webpack Plugin
+# SW Precache Webpack Plugin


Need to remove the extra lines under all the titles that were reformatted

goldhand · 2017-05-02T16:28:06Z

README.md

 ]
 ```

+### `importSripts` usage example
+Uses one option from `sw-precache` (`cacheId`) with one option from `SWPrecacheWebpackPlugin` (`filename`) in a configuration hash:


This doesn't explain the example

goldhand · 2017-05-02T16:28:29Z

README.md

 ]
 ```

-Here's a more elaborate example with `mergeStaticsConfig: true` and `staticFileGlobsIgnorePatterns`. `mergeStaticsConfig: true` allows you to add some additional static file globs to the emitted ServiceWorker file alongside Webpack's emitted assets. `staticFileGlobsIgnorePatterns` can be used to avoid including sourcemap file references in the generated ServiceWorker.
+### `cacheId` usage example
+Uses one option from `sw-precache` (`cacheId`) with one option from `SWPrecacheWebpackPlugin` (`filename`) in a configuration hash:


Probably can remove the cacheId example

goldhand · 2017-05-02T16:39:13Z

src/index.js

+          const chunk = chunks.find(c => c.names.includes(criteria.chunkName));
+
+          if (!chunk) {
+            compilation.errors.push(new Error(


Maybe push this to this.warnings?

I think this should report an error, because it can only happen if they specify a chunk name which does not exist.

This is the only outstanding requested change, I can change it to warning if you insist - but I believe this should prompt the user to remove their definition of invalid chunkName.

Ok sounds good, we can leave it

hulkish · 2017-05-02T17:07:10Z

Looks good overall, a couple changes, mostly to the readme. Also, just to clarify, will importScripts: ['myscript.[hash].js'] still be supported or will they need to use the format importScripts: {filename:myscript.[hash].js'}` to get the legacy hash support

@goldhand I think it should be deprecated in a later release. However, yes - the current usage is legacy supported:

importScripts: ['myscript.[hash].js']

The exact same can also be accomplished using new syntax:

importScripts: [{ filename: 'myscript.[hash].js' }]

Additional Notes:

This will fully respect & support the filename template used for the webpack config's output.filename & output.chunkFilename. So, if your filename or chunkFilename templates use [hash], [chunkhash], [id], [name], etc - it will be processed accordingly.
This supports all types of named chunks. This means you can use an entry point chunk name, or a dynamically imported chunk name: (docs for magic comment syntax here)

module.exports = function() {
  return import(/* webpackChunkName: "service-worker-imported-script-2" */ './service-worker-imported-script-2');
};

Then, in your importScripts config you can directly mention this named chunk:

importScripts: [{ chunkName: 'service-worker-imported-script-2' }]

I added tests for this, also.

…rtScripts[<index>] feature

hulkish · 2017-05-02T17:31:13Z

@goldhand How's that?

goldhand · 2017-05-02T18:44:06Z

README.md

@@ -1,4 +1,4 @@
-SW Precache Webpack Plugin
+# SW Precache Webpack Plugin
 ==========================


forgot this one

goldhand · 2017-05-02T18:48:21Z

@hulkish almost there! Just forgot the ======== at the top of the readme. Then it is good to go. Really great work 👍

hulkish · 2017-05-02T19:07:13Z

@goldhand The line is crushed! Also, updated title of this PR to more accurately represent what this offers.

diachedelic · 2017-10-23T10:49:28Z

How is the [hash] derived when using filename? It does not seem to ever change.

    new CopyWebpackPlugin([
      {
        from: path.resolve(__dirname, '../src/sw-import.js'),
        to: path.resolve(
          config.build.assetsRoot,
          config.build.assetsSubDirectory,
          'js/[name].[hash].[ext]',
        ),
      },
    ]),
    new SWPrecacheWebpackPlugin({
      cacheId: 'static',
      filename: 'service-worker.js',
      staticFileGlobs: ['dist/**/*.{js,html,css,woff}'],
      minify: false,
      stripPrefix: 'dist/',
      importScripts: [{ 
        filename: `${config.build.assetsSubDirectory}/js/sw-import.[hash].js`,
      }],
    }),

If I change either the filename or content of sw-import.js, instead of the hash changing, I always get 09acbae1608b7ed292fd

importScripts("/static/js/sw-import.09acbae1608b7ed292fd.js");

hulkish added 4 commits April 30, 2017 09:45

added yarn.lock file

1323796

added [chunkhash] support via importScripts[<index>].chunkName feature

bdaa9da

updated readme with example usage of importScripts[<index>].chunkName

cdeabb8

added tests for importScripts[<index>].chunkName feature

23ea9f0

hulkish changed the title ~~Added [chunkhash] for importScripts~~ Added [chunkhash] support for importScripts May 1, 2017

hulkish mentioned this pull request May 2, 2017

chunk files are not caching #7

Closed

goldhand requested changes May 2, 2017

View reviewed changes

hulkish added 2 commits May 2, 2017 13:16

applied requested changes to readme, improved explanation of new impo…

68d2198

…rtScripts[<index>] feature

improved docs for importScripts[<index>] feature & improved it's test

fc72c33

goldhand reviewed May 2, 2017

View reviewed changes

removed line from readme

4023850

hulkish changed the title ~~Added [chunkhash] support for importScripts~~ Added [chunkhash]/[hash]/[id]/[name] support for importScripts May 2, 2017

goldhand approved these changes May 2, 2017

View reviewed changes

goldhand merged commit 7308aff into goldhand:master May 2, 2017

goldhand mentioned this pull request May 2, 2017

Please support [chunkhash] for importScripts #60

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added [chunkhash]/[hash]/[id]/[name] support for importScripts #70

Added [chunkhash]/[hash]/[id]/[name] support for importScripts #70

hulkish commented May 1, 2017 •

edited

Loading

hulkish commented May 2, 2017

goldhand commented May 2, 2017

goldhand left a comment

goldhand May 2, 2017

goldhand May 2, 2017

hulkish May 2, 2017

goldhand May 2, 2017

goldhand May 2, 2017

goldhand May 2, 2017

hulkish May 2, 2017

hulkish May 2, 2017 •

edited

Loading

goldhand May 2, 2017

hulkish commented May 2, 2017 •

edited

Loading

hulkish commented May 2, 2017

goldhand May 2, 2017

goldhand commented May 2, 2017

hulkish commented May 2, 2017 •

edited

Loading

diachedelic commented Oct 23, 2017

		@@ -1,4 +1,4 @@
		SW Precache Webpack Plugin
		# SW Precache Webpack Plugin

Added [chunkhash]/[hash]/[id]/[name] support for importScripts #70

Added [chunkhash]/[hash]/[id]/[name] support for importScripts #70

Conversation

hulkish commented May 1, 2017 • edited Loading

hulkish commented May 2, 2017

goldhand commented May 2, 2017

goldhand left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hulkish May 2, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hulkish commented May 2, 2017 • edited Loading

hulkish commented May 2, 2017

Choose a reason for hiding this comment

goldhand commented May 2, 2017

hulkish commented May 2, 2017 • edited Loading

diachedelic commented Oct 23, 2017

hulkish commented May 1, 2017 •

edited

Loading

hulkish May 2, 2017 •

edited

Loading

hulkish commented May 2, 2017 •

edited

Loading

hulkish commented May 2, 2017 •

edited

Loading