Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing issue template for both feature request and bug report #27

Closed
HipsterZipster opened this issue May 8, 2019 · 5 comments
Closed

Comments

@HipsterZipster
Copy link
Collaborator

HipsterZipster commented May 8, 2019

Andy's Proposal for Feature Request:

Please make sure that this is a feature request. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub.

System information

TensorFlow version (you are using):
Are you willing to contribute it (Yes/No):
Describe the feature and the current behavior/state.

Will this change the current api? How?

Who will benefit with this feature?

Any Other info.

Github's Default Proposal for Feature Request

Describe the problem.
A clear and concise description of the problem.

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Are you willing to contribute
Yes/No

Additional context
Add any other context or screenshots about the feature request here

Github's Default Proposal for Bug Report

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

What does everyone think?

@andrewphillipsn
Copy link
Contributor

the first one is the tensorflow example. it asks if you are willing to contribute which is good, so i added that to the github default

@HipsterZipster
Copy link
Collaborator Author

HipsterZipster commented May 8, 2019

Here's the UI for generating the default issue template:
https://github.com/goldmansachs/gs-quant/issues/templates/edit

One thing to point out is that it does eventually generate a series of md files in a folder called .github so we'd have to sync it back

@andrewphillipsn
Copy link
Contributor

thx i created a new template for feature request. on bug report we can simplify, prob just need python version

@andrewphillipsn
Copy link
Contributor

andrewphillipsn commented May 8, 2019

@HipsterZipster bug report format below. wdyt?

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior with reproducible code example.

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

System Setup:

  • OS: [e.g. Windows 10]
  • Python version
  • GS-Quant version [e.g. 0.7]

Additional context
Add any other context about the problem here.

@ScottWeinstein
Copy link
Contributor

LGTM

andrewphillipsn added a commit that referenced this issue May 10, 2019
Adding issue template for bug request per discussion on #27
HipsterZipster pushed a commit that referenced this issue May 10, 2019
Adding issue template for bug request per discussion on #27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants