Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative trait instead of extending class #21

Closed
matthew-inamdar opened this issue Feb 9, 2020 · 2 comments · Fixed by #22
Closed

Alternative trait instead of extending class #21

matthew-inamdar opened this issue Feb 9, 2020 · 2 comments · Fixed by #22
Labels
documentation Documentation needs working on enhancement New feature or request

Comments

@matthew-inamdar
Copy link
Member

Following the proposal of #20, we should definitely add a trait as an alternative to extending the classes provided.

This flexibility allows this package to still be utilised in the event that the client code is already extending their models from a class provided in another package.

This will need to be documented in the README.md.

@matthew-inamdar matthew-inamdar added documentation Documentation needs working on enhancement New feature or request labels Feb 9, 2020
@firmantr3
Copy link

That would be nice! 👍

@matthew-inamdar
Copy link
Member Author

matthew-inamdar commented Feb 13, 2020

@firmantr3 I've created a PR to add trait support. Please check out the docs and give feedback:

Docs: https://github.com/goldspecdigital/laravel-eloquent-uuid/blob/feature/trait/README.md
PR: #22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation needs working on enhancement New feature or request
Development

Successfully merging a pull request may close this issue.

2 participants