Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ModelTrait for more reusability #20

Closed
wants to merge 1 commit into from

Conversation

firmantr3
Copy link

Greetings, I've just started to use this package for my new project that use uuid for its models. It's working great until I need to implement uuid on a model that extends from another package.

The solution that I've done is to copy the entire GoldSpecDigital\LaravelEloquentUUID\Database\Eloquent\Model class properties and methods to that mentioned model. I think this it's better to add a trait so my class would just use that trait.

Best regard,
Firman

@matthew-inamdar
Copy link
Member

Hi @firmantr3 👋

I completely agree! I think a trait would be fantastic to offer as well.

The proposed changes completely remove the base model which becomes a breaking change and also takes away the simple usage of this package.

I'm going to close this PR and open an issue to work on adding a trait as an alternative to the base model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants